Re: [PATCH] Do not skip wifi slave connections

[Nikolay Martynov <mar kolya gmail com>]

Hi.

Thanks for your response!

2017-05-18 11:32 GMT-04:00 Thomas Haller <thaller redhat com>:
> On Tue, 2017-05-16 at 22:13 -0400, Nikolay Martynov wrote:
> > If slave connection is a wifi connection we should still display it
> > Otherwise this AP gets scanned regardless, but when user clicks it
> > new
> > network is created in NM's configuation - which is unlikely what user
> > desired
>
> Hi Nikolay,
>
> I see what the patch does, but I am not convinced that it's the right
> thing to do.
>
> In a way, it changes
> https://git.gnome.org/browse/network-manager-applet/commit/?h=0abe8a8f46bcdce5907882ba355ec69156b33164
>
> Other opinions?

Just to clarify: this patch only affects wifi bonded connections.
'Classic' ethernet bond slaves are still skipped - so this change
should not affect existing users.
I think the intention of original patch was to hide ethernet ones.
The problem with wifi slaves is that they are not hidden since they
actually come from scan results - they still pop up in the list of
available APs. And this is the good thing - this means I can connect
and disconnect wifi bond slave at will from the applet.
So, with this in mind - could you please clarify why you think this is
not the right thing to do so I could try to address that? :)

Thanks!

-- 
Martynov Nikolay.
Email: mar kolya gmail com