Re: [PATCH 1/1] nm-dns-dnsmasq: clear cache when dns server changes

On Tue, 2016-11-29 at 15:03 +0100, Christian Hesse wrote:
From: Christian Hesse <mail eworm de>

A new DNS may have different data for us. So tell dnsmasq to clear
cache when servers change.

Signed-off-by: Christian Hesse <mail eworm de>
 src/dns/nm-dns-dnsmasq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/dns/nm-dns-dnsmasq.c b/src/dns/nm-dns-dnsmasq.c
index 9ef7972..d67693a 100644
--- a/src/dns/nm-dns-dnsmasq.c
+++ b/src/dns/nm-dns-dnsmasq.c
@@ -537,6 +537,7 @@ start_dnsmasq (NMDnsDnsmasq *self)
      argv[idx++] = "--pid-file=" PIDFILE;
      argv[idx++] = "--listen-address="; /* Should work
for both 4 and 6 */
      argv[idx++] = "--cache-size=400";
+     argv[idx++] = "--clear-on-reload"; /* clear cache when dns
server changes */
      argv[idx++] = "--conf-file=/dev/null"; /* avoid loading
/etc/dnsmasq.conf */
      argv[idx++] = "--proxy-dnssec"; /* Allow DNSSEC to pass
through */
      argv[idx++] = "--enable-dbus=" DNSMASQ_DBUS_SERVICE;

Hi Christian,

we currently always do a ClearCache call after SetServerEx.

How does this relate to your patch? Does --clear-on-reload make the
ClearCache call unnecessary? Why is ClearCache not sufficient?


Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]