On Tue, 2016-03-22 at 10:03 -0400, Mathieu Trudel-Lapierre wrote:
Use DBus to make nameserver updates rather than restarting the dnsmasq binary again and again. Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel- lapierre canonical com>
Hi Mathieu, I picked one part of this patch and pushed it as https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=2bb769cf10ab9c19c1690753405352a0f7082dde After that, I did a few minor changes to nm-dns-manager for things I disliked in the existing code. Your patch still mostly applies. Anyway, I took your patch and pushed it to a branch for easier(?) review and sharing. https://cgit.freedesktop.org/NetworkManager/NetworkManager/log/?h=th/dnsmasq-dbus And I added a few fixup commits for style issues and minor bugs. Can I give it back to you in this form and let's take it from there? I dislike a bit the builder-member GVariantBuilder *servers; Could we instead make it a GVariant *set_server_ex_args; Thomas
Attachment:
signature.asc
Description: This is a digitally signed message part