Re: [PATCH v2 1/2] Allow building without gtk-doc installed
- From: Petr Vorel <petr vorel gmail com>
- To: Lubomir Rintel <lkundrak v3 sk>
- Cc: networkmanager-list gnome org
- Subject: Re: [PATCH v2 1/2] Allow building without gtk-doc installed
- Date: Fri, 3 Jul 2015 18:13:23 +0200
Hi Lubomir,
This doesn't look good to me.
autogen.sh is a maintainer tool and we pretty much always want to
create tarballs with GTK-doc.
Why don't you just use autoreconf (with -f and -i) instead of
autogen.sh when doing builds off Git?
Thanks for the tip, but it actually does not work as there is a dependency (as I reported
it before):
$ autoreconf -f -i
<snip>
docs/api/Makefile.am:28: error: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
automake: error: cannot open < gtk-doc.make: No such file or directory
autoreconf: automake failed with exit status: 1
I know this is minor / unimportant issue as not many people will build without GTK-doc.
But still I'd prefer either to require it (to explain user what's wrong - first version of
my patch) or better allow build without it and just warn user (second version of the
patch; there might be better way of doing it than my quirks).
Kind regards,
Petr
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]