[PATCH 1/2] applet/editor: no longer add 'serial' setting
- From: Dan Williams <dcbw redhat com>
- To: networkmanager-list gnome org
- Subject: [PATCH 1/2] applet/editor: no longer add 'serial' setting
- Date: Wed, 01 Jul 2015 16:06:52 -0500
It's not used by NM/MM at all right now (and only relevant to things
that actually use plain old serial ports, like RS232 and some embedded
modems) so don't bother adding it.
---
src/connection-editor/page-mobile.c | 17 -----------------
src/mobile-helpers.c | 10 ----------
2 files changed, 27 deletions(-)
diff --git a/src/connection-editor/page-mobile.c b/src/connection-editor/page-mobile.c
index b15cc1d..56bfd21 100644
--- a/src/connection-editor/page-mobile.c
+++ b/src/connection-editor/page-mobile.c
@@ -427,22 +427,6 @@ ce_page_mobile_class_init (CEPageMobileClass *mobile_class)
object_class->dispose = dispose;
}
-static void
-add_default_serial_setting (NMConnection *connection)
-{
- NMSettingSerial *s_serial;
-
- s_serial = NM_SETTING_SERIAL (nm_setting_serial_new ());
- g_object_set (s_serial,
- NM_SETTING_SERIAL_BAUD, 115200,
- NM_SETTING_SERIAL_BITS, 8,
- NM_SETTING_SERIAL_PARITY, 'n',
- NM_SETTING_SERIAL_STOPBITS, 1,
- NULL);
-
- nm_connection_add_setting (connection, NM_SETTING (s_serial));
-}
-
typedef struct {
NMClient *client;
PageNewConnectionResultFunc result_func;
@@ -498,7 +482,6 @@ new_connection_mobile_wizard_done (NMAMobileWizard *wizard,
g_free (detail);
nm_connection_add_setting (connection, type_setting);
- add_default_serial_setting (connection);
nm_connection_add_setting (connection, nm_setting_ppp_new ());
}
diff --git a/src/mobile-helpers.c b/src/mobile-helpers.c
index d867b35..fc725b9 100644
--- a/src/mobile-helpers.c
+++ b/src/mobile-helpers.c
@@ -193,16 +193,6 @@ mobile_wizard_done (NMAMobileWizard *wizard,
} else
g_assert_not_reached ();
- /* Serial setting */
- setting = nm_setting_serial_new ();
- g_object_set (setting,
- NM_SETTING_SERIAL_BAUD, 115200,
- NM_SETTING_SERIAL_BITS, 8,
- NM_SETTING_SERIAL_PARITY, 'n',
- NM_SETTING_SERIAL_STOPBITS, 1,
- NULL);
- nm_connection_add_setting (connection, setting);
-
nm_connection_add_setting (connection, nm_setting_ppp_new ());
setting = nm_setting_connection_new ();
--
2.1.0
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]