Re: [PATCH 1/1] vpnc: add support to change interface name

On 09/23/2014 04:58 AM, Christian Hesse wrote:
Dan Williams <dcbw redhat com> on Mon, 2014/09/22 10:09:
So this is great, and ties in with some other stuff we're doing.
However, one change I'd like to request.  Instead of putting the
interface name into the VPN data (like the other vpnc-specific options),
lets put it into the NMSettingConnection setting's 'interface-name'

Sounds reasonable.

But (NMConnection *connection) is specific to a VPN connection and does not
have an interface-name property, no? If I got it right I can not pass it to
nm_connection_get_setting_connection() and therefore (NMSettingConnection
*s_con) is missing. So do we have to create (NMConnection *connection) and
(NMConnection *vpn) and pass around both?

No, the NMConnection contains multiple NMSettings (basically, one for
each page of the connection editor). So you can call both
get_setting_connection() and get_setting_vpn() on it.

-- Dan

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]