Re: [PATCH 1/1] vpnc: add support to change interface name

[Christian Hesse <mail eworm de>]

Dan Williams <dcbw redhat com> on Mon, 2014/09/22 10:09:
> On Mon, 2014-09-22 at 10:02 +0200, Christian Hesse wrote:
> > By default interface name is 'tun' with an incrementing number (tun0,
> > tun1, ...). By specifying 'Interface name' in vpnc config you can change
> > the name to something more descriptice.
>
> So this is great, and ties in with some other stuff we're doing.
> However, one change I'd like to request.  Instead of putting the
> interface name into the VPN data (like the other vpnc-specific options),
> lets put it into the NMSettingConnection setting's 'interface-name'
> property.

Sounds reasonable.

But (NMConnection *connection) is specific to a VPN connection and does not
have an interface-name property, no? If I got it right I can not pass it to
nm_connection_get_setting_connection() and therefore (NMSettingConnection
*s_con) is missing. So do we have to create (NMConnection *connection) and
(NMConnection *vpn) and pass around both?

-- 
Schoene Gruesse
Chris
                         O< ascii ribbon campaign
                   stop html mail - www.asciiribbon.org

Attachment: signature.asc
Description: PGP signature