Re: libgsystem as a git submodule, not system wide

[Dan Williams <dcbw redhat com>]

On Wed, 2014-04-02 at 14:03 +0200, poma wrote:
> On 02.04.2014 11:05, Thomas Haller wrote:
> > Hi,
> >
> > On Wed, 2014-04-02 at 06:32 +0200, poma wrote:
> > Why the 'libgsystem' is used as a git submodule, and not via the system
> > > wide setup - 'libgsystem/devel'?
> >
> > Because originally libgsystem was not available in distributions (or not
> > recent enough). That could be revised in the future, if it bothers
> > somebody enough.
> >
> >
> > > I suppose this is the git way to acquire the source code to build a
> > > local tarball,
> > > git clone git://anongit.freedesktop.org/NetworkManager/NetworkManager
> > > cd NetworkManager/
> > > git submodule init
> > > git submodule update
> > > ./autogen.sh
> > > cd ../
> > > tar ...
> >
> >
> > If you want to create a source tarball, a better way might be:
> >
> > git clone git://anongit.freedesktop.org/NetworkManager/NetworkManager
> > cd NetworkManager/
> > ./autogen.sh --enable-gtk-doc && make && make dist
> >
> >
> > I think, upstream creates it's tarball this way.
> >
> >
> >
> >
> > > Perhaps this is the reason, however it is still a mystery why are
> > > snapshots created with a blank 'libgsystem/'!?
> >
> > I don't understand which snapshots you are referring to. If you do what
> > you said, you populate libgsystem/ before calling tar.
> >
> >
> >
> > Thomas.
>
> ./autogen.sh --enable-gtk-doc
> ...
> configure.ac:33: installing 'build-aux/missing'
> automake: error: cannot open < libgsystem/Makefile-libgsystem.am: No
> such file or directory
> autoreconf: automake failed with exit status: 1
>
> Snapshots/tarballs:
> e.g.
> http://cgit.freedesktop.org/NetworkManager/NetworkManager/
> http://cgit.freedesktop.org/NetworkManager/NetworkManager/snapshot/NetworkManager-0.9.9.1.tar.gz
> http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=e9fdfa1
> http://cgit.freedesktop.org/NetworkManager/NetworkManager/snapshot/NetworkManager-e9fdfa1.tar.gz
> etc.

I think danw had talked about removing the sub-module, and just copying
the pieces we use into NetworkManager's source tree.  If we start using
more libgsystem (perhaps the subprocess stuff) then we could
re-evaluate.  Anyone have thoughts/reactions to that?

Dan