Re: [PATCH] core: fix bridge device creation



On Mon, 2013-09-16 at 23:59 +0200, loic yhuel gmail com wrote:
From: Loïc Yhuel <loic yhuel gmail com>

Since 2688ae4950070f2a57db1347d9ebfbce0898fe53, bridge device creation
fails with "(br0): cannot use existing bridge for 'Bridge'" warning.
---
 src/nm-manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/nm-manager.c b/src/nm-manager.c
index 0bad830..11e3b5e 100644
--- a/src/nm-manager.c
+++ b/src/nm-manager.c
@@ -1439,7 +1439,7 @@ system_create_virtual_device (NMManager *self, NMConnection *connection)
              device = nm_device_team_new_for_connection (connection);
      } else if (nm_connection_is_type (connection, NM_SETTING_BRIDGE_SETTING_NAME)) {
              /* FIXME: remove when we handle bridges non-destructively */
-             if (!nm_platform_link_get_ifindex (iface) > 0 && !bridge_created_by_nm (self, iface)) {
+             if (nm_platform_link_get_ifindex (iface) > 0 && !bridge_created_by_nm (self, iface)) {
                      nm_log_warn (LOGD_DEVICE, "(%s): cannot use existing bridge for '%s'",
                                   iface, nm_connection_get_id (connection));
              } else


Hi,

Patch pushed to master, see:
http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=19b7fe5ca2616ade156bdc27c408f1471648a712

Thank you!!
Thomas

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]