nm-applet crashes if a broadband connection is an auto connection and no other connection is available



Hi,

nm-applet crashes if a broadband connection is an auto connection and no other connection is available.

In this case devinfo is never filled with data, because this is triggered in device_added which wasn't be invoced when the function applet_get_device_icon_for_state (in applet.c) is called.
So the function get_icon in applet-device-broadband.c gives an assertion

device_added:
        /* Store device info */
        g_object_set_data_full (G_OBJECT (modem),
                                "devinfo",
                                info,
(GDestroyNotify)broadband_device_info_free);

At the moment this patch works for us:

--- src/applet-device-broadband.c.orig  2013-11-27 14:15:36.000000000 +0100
+++ src/applet-device-broadband.c       2013-11-27 14:16:04.000000000 +0100
@@ -631,6 +631,10 @@
        BroadbandDeviceInfo *info;

        info = g_object_get_data (G_OBJECT (device), "devinfo");
+       if(info == 0)
+           {
+           return ;
+           }
        g_assert (info);

        return mobile_helper_get_icon (device,



Harald


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]