[PATCH] dnsmasq: does handle more than one nameserver per domain



http://nottheoilrig.com/networkmanager/201307040/perdomain.patch

Here is the patch ^

Hello,

Recently I spotted the FIXME in nm-dns-dnsmasq.c that says dnsmasq can only handle one nameserver per domain, and I spotted these comments from Simon Kelley (dnsmasq author) that say it is not the case:


https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1003842/comments/58

https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1003842/comments/55

The problem with more than one nameserver per domain is that dnsmasq always handles them as if --strict-order was enabled. If --strict-order is not enabled, it should query them non-deterministically in the normal dnsmasq manner. He says he plans to correct this, but either way, dnsmasq does handle more than one nameserver per domain.

In the second comment he points out that NetworkManager loses subsequent nameservers and only passes one per-domain nameserver to dnsmasq. This patch fixes that.

It passes all per-domain nameservers to dnsmasq and removes the FIXME. I would like to contribute the patch to NetworkManager, and am happy to make any changes you request.

Thanks!


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]