Re: [PATCH] dns: store priv->last_iface even when no actual updates are performed



On Wed, 2013-02-13 at 21:11 +0100, Michael Stapelberg wrote:
> Hi Dan,
> 
> Sorry for replying late and thanks for taking care of this.
> 
> Dan Williams <dcbw redhat com> writes:
> > So I'll propose a different solution:  check the last patch in the
> > dcbw/dns-iface git branch, and let me know if that works for you?
> >
> > http://cgit.freedesktop.org/NetworkManager/NetworkManager/log/?h=dcbw/dns-iface
> This branch no longer exists, but I presume you have merged it and it
> contained the commit
> http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=778d1cf2e8af334e8f1c922ed405c351f38b020a
> 
> I have upgraded to NetworkManager git 08f0446 and can confirm that the
> symptom I have been reporting is now fixed.
> 
> Do note that my DNS configuration now does contain a duplicate entry,
> though:
> 
> cat /var/run/NetworkManager/dnsmasq.conf
> server=192.168.1.1
> server=fe80::4e60:deff:fed8:d7c5 eth0
> server=192.168.1.1
> server=fe80::4e60:deff:fed8:d7c5 wlan0
> 
> I suppose it doesnât really hurt, at least not in my case, but wouldnât
> it be cleaner if entry was only listed once? :-)

Yeah, probably.  I assume it would be sufficient to just not list the
IPv4 nameserver twice?

Dan




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]