Re: [MM][PATCH] remove comparison of unsigned expression >= 0
- From: Ben Chan <benchan chromium org>
- To: Aleksander Morgado <aleksander lanedo com>
- Cc: networkmanager-list gnome org
- Subject: Re: [MM][PATCH] remove comparison of unsigned expression >= 0
- Date: Mon, 29 Apr 2013 09:23:44 -0700
How about the cid case? cid == 0 seems to be an invalid value?
On Apr 28, 2013 10:55 PM, "Aleksander Morgado" <
aleksander lanedo com> wrote:
On 27/04/13 08:00, Ben Chan wrote:
> [Ben] Aleksander, do you think the original code was meant to check
> "quality > 0"?
>
>> > + if (!max) {
>> > /* If we didn't get a max, assume it was 5. Note that we do allow
>> > * 0, meaning no signal at all. */
According to the comment just after that, zero is allowed.
--
Aleksander
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]