Re: [MM][PATCH] gobi: Add qmi_wwan to the list of drivers for plugin initiation.

[Aleksander Morgado <aleksander lanedo com>]

On 04/09/2013 06:19 PM, Dan Williams wrote:
> On Tue, 2013-04-09 at 13:11 +0200, Aleksander Morgado wrote:
> > On 04/08/2013 11:51 PM, Arman Uguray wrote:
> > > Added "qmi_wwan" as one of the supported drivers for the Gobi plugin.
> >
> > Is there any modem which doesn't work without this fix?
> >
> > I know it seems a clear fix to do, but it may have some side effects.
> > The drivers filter was thought for the qcserial case, so that if we ever
> > detect a modem with ttys handled by qcserial, we decide it's a Gobi
> > modem. Now, the filter is exclusive, if the Gobi plugin accepts the
> > port, it won't be accepted by any other plugin. And we don't want all
> > QMI-powered modems being grabbed by the Gobi plugin (e.g. ZTE modems
> > *suck* at QMI, so we never actually run them in QMI mode)...
>
> Would this make the Gobi plugin potentially grab Pantech QMI devices too
> (eg uml290), depending on plugin load order?  There's actually quite a
> few devices that are driven by qmi_wwan that *aren't* Gobi devices.

Possibly, yes. Actually I think we should make the Gobi plugin get
sorted after all the other plugins allowing QMI, so that we only get
probing done with it once we have checked the others.


> Dan
>
> > > ---
> > >  plugins/gobi/mm-plugin-gobi.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/plugins/gobi/mm-plugin-gobi.c b/plugins/gobi/mm-plugin-gobi.c
> > > index 6f2280d..ac32ae8 100644
> > > --- a/plugins/gobi/mm-plugin-gobi.c
> > > +++ b/plugins/gobi/mm-plugin-gobi.c
> > > @@ -68,7 +68,7 @@ G_MODULE_EXPORT MMPlugin *
> > >  mm_plugin_create (void)
> > >  {
> > >      static const gchar *subsystems[] = { "tty", "net", "usb", NULL };
> > > -    static const gchar *drivers[] = { "qcserial", NULL };
> > > +    static const gchar *drivers[] = { "qcserial", "qmi_wwan", NULL };
> > >  
> > >      return MM_PLUGIN (
> > >          g_object_new (MM_TYPE_PLUGIN_GOBI,
>
>
> _______________________________________________
> networkmanager-list mailing list
> networkmanager-list gnome org
> https://mail.gnome.org/mailman/listinfo/networkmanager-list


-- 
Aleksander