Re: [MM][PATCH] gobi: Add qmi_wwan to the list of drivers for plugin initiation.



On 04/08/2013 11:51 PM, Arman Uguray wrote:
Added "qmi_wwan" as one of the supported drivers for the Gobi plugin.


Is there any modem which doesn't work without this fix?

I know it seems a clear fix to do, but it may have some side effects.
The drivers filter was thought for the qcserial case, so that if we ever
detect a modem with ttys handled by qcserial, we decide it's a Gobi
modem. Now, the filter is exclusive, if the Gobi plugin accepts the
port, it won't be accepted by any other plugin. And we don't want all
QMI-powered modems being grabbed by the Gobi plugin (e.g. ZTE modems
*suck* at QMI, so we never actually run them in QMI mode)...

---
 plugins/gobi/mm-plugin-gobi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/gobi/mm-plugin-gobi.c b/plugins/gobi/mm-plugin-gobi.c
index 6f2280d..ac32ae8 100644
--- a/plugins/gobi/mm-plugin-gobi.c
+++ b/plugins/gobi/mm-plugin-gobi.c
@@ -68,7 +68,7 @@ G_MODULE_EXPORT MMPlugin *
 mm_plugin_create (void)
 {
     static const gchar *subsystems[] = { "tty", "net", "usb", NULL };
-    static const gchar *drivers[] = { "qcserial", NULL };
+    static const gchar *drivers[] = { "qcserial", "qmi_wwan", NULL };
 
     return MM_PLUGIN (
         g_object_new (MM_TYPE_PLUGIN_GOBI,



-- 
Aleksander


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]