Re: [PATCH] Allow NetworkManager-SSH plugin

[Dan Fruehauf <malkodan gmail com>]

In theory I agree Dan. However even in dbus-daemon man page it says:

"SIGHUP  will  cause the D-Bus daemon to PARTIALLY reload its configuration file..."

Partially? Interesting.

But anyway, what I've outlined above are my observations. The comment in NetworkManager's dbus configuration is still valid.

On Wed, Apr 3, 2013 at 4:15 AM, Dan Williams <dcbw redhat com> wrote:

On Tue, 2013-04-02 at 01:33 -0400, Pavel Simerda wrote:
> > From: "Dan Fruehauf" <malkodan gmail com>
> > My findings so far about that matter, regarding VPN plugins for
> > NetworkManager and their dbus policies.
> > 1. Vanilla /etc/dbus-1/system.d (without the SSH rules)
> > 2. Things don't work
> > 3. Adding the nm-ssh-service.conf file (to allow SSH access)
> > 4. Still things won't work
> > 5. pgrep dbus-daemon | xargs kill -HUP
> > 6. Things still won't work
> > 7. Adding the specific rule in org.freedesktop.NetworkManager.conf
> > 8. pgrep dbus-daemon | xargs kill -HUP
> > 9. Things still don't work
> > 10. /bin/systemctl reload NetworkManager.service
> > 11. We're good to go
> >
> > Looks like it's nice to add this patch, but altogether a restart for
> > NetworkManager will be required if you install a new VPN plugin with
> > policies that were not included in org.freedesktop.NetworkManager.conf
> > originally.
> >
> > Mmmmm. What can we do about it?
> >
> > Supposedly new plugins can request a restart for NetworkManager (in their
> > %post) section, but that's rather ugly. Any other suggestions?
>
> I used to think that dbus was a great tool. Until I started actually using it. Unfortunately my knowledge of dbus internals are poor but this looks like a bug or at least a missing feature with dbus. Hope someone corrects me and says it's properly fixable in NetworkManager.

dbus should be watching the /etc/dbus-1/system.d directory for new rules
files and automatically adding the rules to it's internal access control
checking.  You can trigger reloads using SIGHUP (see man dbus-daemon),
but they shouldn't be necessary.

NM should also be noticing the new new .name file and printing a message
to its logs.

Dan