Re: [MM] [PATCH] sierra: add support for new !SELRAT values in newer Sierra LTE modems

[Dan Williams <dcbw redhat com>]

On Mon, 2012-09-10 at 23:39 +0200, Marius Kotsbak wrote:
> On 10. sep. 2012 18:54, Dan Williams wrote:
> > On Sat, 2012-09-08 at 00:49 +0200, Marius Kotsbak wrote:
> >> 2012/9/7 Dan Williams<dcbw redhat com>
> >>          On Mon, 2012-09-03 at 18:24 +0200, Marius Kotsbak wrote:
> >>          > Patch attached again in right format.
> >>          
> >>          
> >>          Backported and pushed to 0.6.
> >>          
> >>
> >>
> >> Great! Now it seems we just need to add support for 4G preference in
> >> nm-applet to actually use this?
> > Yes.
> 
> It seemed to actually work with this and the patches I sent for NM and 
> nm-applet. There are probably other modem plugins that needs to be 
> updated as well.
> 
> >> The backport is though slightly wrong:
> >>
> >>
> >>       case MM_MODEM_GSM_ALLOWED_MODE_2G_PREFERRED:
> >>           idx = 4;
> >>           break;
> >>       case MM_MODEM_GSM_ALLOWED_MODE_3G_PREFERRED:
> >>           idx = 3;
> >>           break;
> >>
> >>
> >> Modes 3 and 4 will include LTE, so it is probably better to use mode 5
> >> for both of these (and maybe refuse 2G preferred) for LTE modem, else
> >> it is impossible to select 2G/3G mode (exclude LTE).
> > Any chance you could do a quick patch for that?
> 
> Attached.

Pushed, thanks!

Dan