Re: [MM] [PATCH 4/5] novatel: Poll for whether the connection still exists.

On Mon, May 7, 2012 at 10:37 AM, Aleksander Morgado <aleksander lanedo com> wrote:

   Given that the $NWQMISTATUS reply is not bearer-specific (reports
   overall status of the modem), I was thinking in moving the periodic
   connectivity check to MMIfaceModem instead, and plug it in using the
   same logic as e.g. the signal quality check. In that way, other
   implementations (e.g. Samsung) could benefit from the same generic
   timeout handling logic. What do you think?

Is it useful to other implementations? I consider the periodic
connectivity check a hack to work around Novatel's fairly broken
firmware and complete lack of unsolicited notifications. If other modems
are also bad at this, that seems fine, but I'd like to resist
generalizing features when there's really only one instance of the problem.

Oh, I thought your Samsung plugin also needed this; may have overlooked it.

My Samsung plugin also notifies the core about disconnection events, which may be what you are remembering. In that case it's in response to an unsolicited message, though; it doesn't have to poll.

    - Nathan

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]