Re: [MM] [PATCH 5/5] novatel: Remove band-setting implementation to improve connections

I'm leery of including code that can run the $NWBAND command to set the modem's state, since as far as I can tell it simply breaks the modem, at least until it is power-cycled. Not setting the bands in the simple connect process unless explicitly requested seems like a fine change on its own, but I think this is too dangerous to include.

    - Nathan

On Wed, May 2, 2012 at 6:29 AM, Aleksander Morgado <aleksander lanedo com> wrote:
On 05/01/2012 06:09 PM, Nathan Williams wrote:
> Subject: [PATCH 5/5] novatel: Remove band-setting implementation to improve
>  connections
> The $NWBAND command seems to disturb the internal state of the modem
> such that it is unlikely to connect to the network, and produces
> widely varying error codes. We don't actively use this functionality,
> it's just that setting "use all bands" is part of the normal
> ModemManager simple-connect sequence. Remove it so it doesn't get
> triggered.

I would leave this code around, and instead make sure that if no
bands-specific configuration is given in the simple connect properties,
we don't try to do anything with the bands setup. What do you think?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]