Re: [MM] [PATCH] iface-modem: increase number of trials for PIN check from 3 to 6

[Aleksander Morgado <aleksander lanedo com>]

On 08/10/2012 08:05 AM, Ben Chan wrote:
> In practice, it may take longer time for a SIM to become ready when the
> modem interface tries to use AT+CPIN? to determine if the SIM is
> PIN-locked. This patch increases the number of trials for PIN check to
> address the issue.

Pushed now, thanks.

> ---
>  src/mm-iface-modem.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c
> index d347281..c8d1b96 100644
> --- a/src/mm-iface-modem.c
> +++ b/src/mm-iface-modem.c
> @@ -2124,9 +2124,9 @@ unlock_check_ready (MMIfaceModem *self,
>                  error->message);
>          g_error_free (error);
>  
> -        /* Retry up to 3 times */
> +        /* Retry up to 6 times */
>          if (mm_gdbus_modem_get_unlock_required (ctx->skeleton) != MM_MODEM_LOCK_NONE &&
> -            ++ctx->pin_check_tries < 3) {
> +            ++ctx->pin_check_tries < 6) {
>              mm_dbg ("Retrying (%u) unlock required check", ctx->pin_check_tries);
>              if (ctx->pin_check_timeout_id)
>                  g_source_remove (ctx->pin_check_timeout_id);
> 


-- 
Aleksander