Re: [PATCH] supplicant: Don't leak secrets, even if they're probably invalid

[Dan Williams <dcbw redhat com>]

On Thu, 2011-09-15 at 00:57 -0700, Evan Broder wrote:
> ---
>  src/supplicant-manager/nm-supplicant-config.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Pushed to 0.9 and 0.8, thanks.

Dan


> diff --git a/src/supplicant-manager/nm-supplicant-config.c b/src/supplicant-manager/nm-supplicant-config.c
> index c651e0f..4860314 100644
> --- a/src/supplicant-manager/nm-supplicant-config.c
> +++ b/src/supplicant-manager/nm-supplicant-config.c
> @@ -123,7 +123,7 @@ nm_supplicant_config_add_option_with_type (NMSupplicantConfig *self,
>  			char buf[255];
>  			memset (&buf[0], 0, sizeof (buf));
>  			memcpy (&buf[0], value, len > 254 ? 254 : len);
> -			nm_log_warn (LOGD_SUPPLICANT, "Key '%s' and/or value '%s' invalid.", key, buf);
> +			nm_log_warn (LOGD_SUPPLICANT, "Key '%s' and/or value '%s' invalid.", key, secret ? "<omitted>" : buf);
>  			return FALSE;
>  		}
>  	}