Re: [PATCH] Configure option --disable-crashtrace to disable GNU backtrace extensions.
- From: Dan Williams <dcbw redhat com>
- To: David Röthlisberger <david rothlis net>
- Cc: networkmanager-list <networkmanager-list gnome org>
- Subject: Re: [PATCH] Configure option --disable-crashtrace to disable GNU backtrace extensions.
- Date: Wed, 05 Oct 2011 17:07:30 -0500
On Wed, 2011-10-05 at 17:22 +0100, David Röthlisberger wrote:
> The attached patch provides a configure option to disable GNU backtrace extensions (for non-glibc toolchains).
>
> The patch is off the NM_0_8 branch, but if you like it I can work on a patch for master.
Thanks, applied to both 0.8 and 0.9. In 0.8 though, we can't simply
check for ENABLE_CRASHTRACE in nm-utils.h, because it'll never be
TRUE/1. That's because we can't include "config.h" there, because
nm-utils.h is a distributed header and config.h is build-time only. So
your patch there effectively disabled it always.
However, nm_print_backtrace() was pointless and thus I've deprecated it
and removed the implementation from nm-utils.h on the 0.8 branch. It's
already gone in 0.9.
Dan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]