Re: glib >= 2.31.0 Threads and Mutexes
- From: Jirka Klimes <jklimes redhat com>
- To: networkmanager-list gnome org
- Cc: martinbts gmx net
- Subject: Re: glib >= 2.31.0 Threads and Mutexes
- Date: Mon, 14 Nov 2011 14:18:52 +0100
On Monday 31 of October 2011 15:26:48 martinbts gmx net wrote:
> Hello list!
>
> There was a change in the threads and mutexes API in glib starting with
> version 2.31, see http://git.gnome.org/browse/glib/tree/NEWS. Especially
> g_thread_init(), g_thread_create(), g_mutex_new() and g_mutex_free() are
> gone. I replaced those as follows:
>
> - made g_thread_init conditional, as demonstrated in
> https://bugs.freedesktop.org/show_bug.cgi?id=42036. - conditionally
> replaced g_thread_create() with g_thread_new(). NetworkManager never
> catches errors and threads seem always joinable now, so the change is
> straight forward replace and satisfy g_thread_new() signature -
> g_mutex_new() replaced by static declarations of GMutex-es and
> (conditionally) passing their references where g_mutex_new() used to be
> called - g_mutex_free() removed (conditionally)
>
> I came across this problem while building Gnome3 using jhbuild, so this
> patch should be against git HEAD (or its equivalent given a central
> repository).
>
> Kind regards
>
> Martin
>
>
>
Fixed by this commit:
http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=4d1d3b9935fca45ff98e1e705ce74540d234c41b
Jirka
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]