Re: [PATCH] Tweak NM-wait-online.service

[Dan Williams <dcbw redhat com>]

On Tue, 2011-05-10 at 17:17 -0400, Bill Nottingham wrote:
> Comments? With this, distributions who wanted to could unilaterally enable
> this service and yet have it only slow down the boot when something
> explicitly is asking for synchronization on network availability.

This got pushed, thanks.

Dan

> (I still don't think we would ship Fedora this way, but some other
> distribution might.)
> 
> Bill
> 
> commit 50b836e1e0008d2df97dbe6eda97551ba13776b3
> Author: Bill Nottingham <notting redhat com>
> Date:   Tue May 10 17:12:56 2011 -0400
> 
>     Tweak NM-wait-online.service.
>     
>     1) Don't require NM, but run after it. This allows this service to be installed without
>     bringing up NetworkManager. Add -x so that it exits if NM isn't running.
>     
>     2) Install as a want of network.target, instead of multi-user.target. This allows us to skip it
>     if nothing requires network.target or the legacy $network SysV capability.
> 
> diff --git a/data/NetworkManager-wait-online.service.in b/data/NetworkManager-wait-online.service.in
> index 1a43d17..0772568 100644
> --- a/data/NetworkManager-wait-online.service.in
> +++ b/data/NetworkManager-wait-online.service.in
> @@ -1,12 +1,12 @@
>  [Unit]
>  Description=Network Manager Wait Online
> -Requires=NetworkManager.service
> +After=NetworkManager.service
>  Wants=network.target
>  Before=network.target
>  
>  [Service]
>  Type=oneshot
> -ExecStart=@bindir@/nm-online -q --timeout=30
> +ExecStart=@bindir@/nm-online -q -x --timeout=30
>  
>  [Install]
> -WantedBy=multi-user.target
> +WantedBy=network.target
> _______________________________________________
> networkmanager-list mailing list
> networkmanager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list