ModemManager patches to fix build warnings



Hi all,

Find attached some patches which fix the warnings issued when
bootstrapping the ModemManager project (0001 and 0002); as well as some
other minor autotools things (0003 and 0004).

One of the patches (0002) needs to bump the autoconf requirement to
2.60; which shouldn't be a big issue.

Cheers,

-- 
Aleksander
>From 34958190e198065beaaabcc3ac9cf9b9cdc50d35 Mon Sep 17 00:00:00 2001
From: Aleksander Morgado <aleksander lanedo com>
Date: Mon, 28 Mar 2011 11:24:39 +0200
Subject: [PATCH 1/4] build: fix automake portability warnings

Makefile.am uses several GNU gcc extensions. -Wno-portability will avoid
emiting portability warnings during bootstrap.
---
 configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index 4f8b94f..af04304 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,7 +1,7 @@
 AC_PREREQ(2.52)
 
 AC_INIT(ModemManager, 0.4, dcbw redhat com, ModemManager)
-AM_INIT_AUTOMAKE([1.9 subdir-objects tar-ustar no-dist-gzip dist-bzip2])
+AM_INIT_AUTOMAKE([1.9 subdir-objects tar-ustar no-dist-gzip dist-bzip2 -Wno-portability])
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 AM_MAINTAINER_MODE
 
-- 
1.7.1

>From b8504be68f90bc6fa0d9ee875c7ecc0e22801f07 Mon Sep 17 00:00:00 2001
From: Aleksander Morgado <aleksander lanedo com>
Date: Mon, 28 Mar 2011 11:30:10 +0200
Subject: [PATCH 2/4] build: require autoconf 2.60 and fix warnings

AC_GNU_SOURCE is deprecated, AC_USE_SYSTEM_EXTENSIONS (introduced in
autoconf 2.60) should be used instead.
---
 configure.ac |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index af04304..1ffef38 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,4 +1,4 @@
-AC_PREREQ(2.52)
+AC_PREREQ(2.60)
 
 AC_INIT(ModemManager, 0.4, dcbw redhat com, ModemManager)
 AM_INIT_AUTOMAKE([1.9 subdir-objects tar-ustar no-dist-gzip dist-bzip2 -Wno-portability])
@@ -9,15 +9,15 @@ AC_CONFIG_MACRO_DIR([m4])
 
 AC_CONFIG_HEADERS(config.h)
 
+dnl Define system extensions for various things like strcasestr()
+AC_USE_SYSTEM_EXTENSIONS
+
 dnl Required programs
 AC_PROG_CC
 AM_PROG_CC_C_O
 AC_PROG_INSTALL
 AC_PROG_LIBTOOL
 
-dnl Define _GNU_SOURCE for various things like strcasestr()
-AC_GNU_SOURCE
-
 dnl
 dnl translation support
 dnl
-- 
1.7.1

>From f043f17e94fade30edf992087fb393abbd92f2e4 Mon Sep 17 00:00:00 2001
From: Aleksander Morgado <aleksander lanedo com>
Date: Mon, 28 Mar 2011 18:09:48 +0200
Subject: [PATCH 3/4] build: use LT_INIT to initialize libtool, and require at least 2.2

---
 configure.ac |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index 1ffef38..2224c1f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -16,7 +16,10 @@ dnl Required programs
 AC_PROG_CC
 AM_PROG_CC_C_O
 AC_PROG_INSTALL
-AC_PROG_LIBTOOL
+
+dnl Initialize libtool
+LT_PREREQ([2.2])
+LT_INIT
 
 dnl
 dnl translation support
-- 
1.7.1

>From 4aa01841b7eb6b1c762bc43e75fad7d214a6a9ac Mon Sep 17 00:00:00 2001
From: Aleksander Morgado <aleksander lanedo com>
Date: Mon, 28 Mar 2011 18:14:06 +0200
Subject: [PATCH 4/4] build: use brackets in autoconf initialization macros

---
 configure.ac |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 2224c1f..436461f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,6 +1,6 @@
-AC_PREREQ(2.60)
+AC_PREREQ([2.60])
 
-AC_INIT(ModemManager, 0.4, dcbw redhat com, ModemManager)
+AC_INIT([ModemManager],[0.4],[dcbw redhat com],[ModemManager])
 AM_INIT_AUTOMAKE([1.9 subdir-objects tar-ustar no-dist-gzip dist-bzip2 -Wno-portability])
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 AM_MAINTAINER_MODE
-- 
1.7.1



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]