Re: Patch for ModemManager (0.4.997) that will make my GSM-card work

[Dan Williams <dcbw redhat com>]

On Wed, 2011-06-29 at 23:17 +0300, Thomas Grenman wrote:
> Hello
> 
> Please consider including the patch below into upcoming versions of 
> ModemManager. This patch will make my Option GlobeTrotter Express GSM-card 
> work together with NetworkManager.
> 
> The patch simply changes the order of the CNMI and CPMS AT-commands. My 
> card will hang if CNMI is sent before CPMS.

Huh.  Just for reference, what's the model number and firmware version
of your card?  The firmware version is AT+GMR (or MM will print it out
if you run it with --debug) and the  model number is usually on the
bottom.  I've got a bunch of Option devices (both USB, CardBus, and
ExpressCard), I'll try to reproduce the error with some of those.

But in the end, I think this patch is harmless on other devices.

Dan

> br, Thomas
> 
> 
> --- ModemManager-0.4.997/src/mm-generic-gsm.c	2011-06-06 17:42:16.000000000 +0300
> +++ ModemManager-0.4.997/src/mm-generic-gsm.c.atcommandflow	2011-06-29 21:48:14.138382934 +0300
> @@ -1438,10 +1438,10 @@
>           mm_at_serial_port_queue_command (priv->primary, cmd, 3, NULL, NULL);
>       g_free (cmd);
> 
> -    /* Enable SMS notifications */
> -    mm_at_serial_port_queue_command (priv->primary, "+CNMI=2,1,2,1,0", 3, NULL, NULL);
>       /* Set SMS storage location to ME */
>       mm_at_serial_port_queue_command (priv->primary, "+CPMS=\"ME\",\"ME\",\"ME\"", 3, NULL, NULL);
> +    /* Enable SMS notifications */
> +    mm_at_serial_port_queue_command (priv->primary, "+CNMI=2,1,2,1,0", 3, NULL, NULL);
> 
>       mm_at_serial_port_queue_command (priv->primary, "+CIND=?", 3, cind_cb, self);
> 
> 
> _______________________________________________
> networkmanager-list mailing list
> networkmanager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list