Re: [ModemManager] [PATCH] mm_gsm_parse_scan_response(): Improve regex-construction error handling
- From: Dan Williams <dcbw redhat com>
- To: Nathan Williams <njw google com>
- Cc: networkmanager-list gnome org
- Subject: Re: [ModemManager] [PATCH] mm_gsm_parse_scan_response(): Improve regex-construction error handling
- Date: Fri, 02 Dec 2011 13:06:35 -0600
On Wed, 2011-11-30 at 17:33 -0500, Nathan Williams wrote:
> And this time with the patch.
Pushed, thanks.
Dan
> - Nathan
>
> On Wed, Nov 30, 2011 at 2:07 PM, Nathan Williams <njw google com> wrote:
> > This was the only code in ModemManager using g_error(), and not
> > appropriately, I think.
> > The codebase is still mixed on how to handle errors compiling regular
> > expressions; other places in this file use g_assert(), while the rest
> > of the code tends to report some kind of parse-failure error. Perhaps
> > this makes sense in terms of startup versus while-running operations?
> >
> > - Nathan
> >
> _______________________________________________
> networkmanager-list mailing list
> networkmanager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]