Re: [PATCH] Re: NetworkManager reset MAC address

[Jirka Klimes <jklimes redhat com>]

On Saturday 25 of September 2010 06:00:43 Dan Williams wrote:
> On Wed, 2010-09-22 at 10:29 +0200, Jirka Klimes wrote:
> > On Tuesday 21 of September 2010 00:47:42 Dan Williams wrote:
> > > On Wed, 2010-09-01 at 16:31 +0200, Jirka Klimes wrote:
> > > > On Tuesday 31 of August 2010 12:26:05 mmsim6 gmail com wrote:
> > > > > I wrote a udev rule to change the MAC address of my wireless card
> > > > > and it worked correctly until I upgraded to
> > > > > NetworkManager-0.8.1-4.git20100817.fc13.x86_64
> > > > > today. Now I find the MAC is reset back to the original address by
> > > > > NetworkManager.
> > > > > How to stop this new feature?
> > > > 
> > > > The new NetworkManager has implemented MAC spoofing feature just for
> > > > this purpose.
> > > > In connection editor,  on 'Wireless' tab there is a new edit box
> > > > 'Cloned MAC address'. If you put your desired MAC here, it will be
> > > > set on an interface when the connection is activated. And you don't
> > > > need to change your MAC in udev or any other way.
> > > > See https://bugzilla.redhat.com/show_bug.cgi?id=447827
> > > 
> > > Yeah, though I think if something has set the MAC before NM starts, we
> > > probably want to make NM read that MAC address in as a spoofed MAC when
> > > NM starts.  I'm not sure we do that yet?  Basically respect the
> > > configuration that exists for both permanent MAC and spoofed MAC when
> > > NM starts up if we can.
> > > 
> > > Dan
> > 
> > The problem is that we currently reset the MAC to permanent MAC address
> > and thus ignoring the MAC that has been changed before NM starts.
> > The attached patch reads the MAC set on interface when NM starts and when
> > uses that when resetting MAC. Thus, NM won't interfere with other
> > settings and won't annoyingly keep putting permanent MAC to the
> > interface.
> 
> Looks good, please push to both 0.8 and master.
> 
> Thanks!
> Dan

Thanks for review.
Pushed.

Jirka