Re: [PATCH] Re: How to find the NM version?

[Jirka Klimes <jklimes redhat com>]

On Saturday 25 of September 2010 05:56:25 Dan Williams wrote:
> On Wed, 2010-09-22 at 16:46 +0200, Jirka Klimes wrote:
> > On Wednesday 23 of September 2009 06:40:03 Dan Williams wrote:
> > > On Tue, 2009-09-22 at 17:44 -0700, Raj Sidh wrote:
> > > > Hello,
> > > > 
> > > > I find that some NetworkManager dbus APIs are of older version in
> > > > some distros (e.g. Ubuntu 8.04) whereas Fedora 9 seems to have what
> > > > is listed under
> > > > http://projects.gnome.org/NetworkManager/developers/spec.html which
> > > > apparently is 0.7.0. How do I determine what version of NM I am
> > > > running so I can make right choices (bus.GetDevices() vs.
> > > > bus.getDevices() and similar) ?
> > > 
> > > Programmatically, you can use some tricks to figrue it out like you
> > > mention, but Tambet also proposed the addition of a Version property on
> > > the /org/freedesktop/NetworkManager base object that we can add to both
> > > 0.7.2 and 0.8+.
> > > 
> > > 0.7.0 vs. 0.7.1 shouldn't be difference to care about, it's mostly
> > > between 0.6, 0.7, and 0.8.
> > > 
> > > Dan
> > 
> > I think Version property is really helpful. I don't know whether a patch
> > exists. Anyway, I'm attaching a patch to add the property.
> 
> Looks good, please push it to 0.8 and master.
> 
> Thanks!
> Dan

Thanks for review.
Pushed.

Jirka