Re: NM can't save password of VPN connection in system scope

[cee1 <fykcee1 gmail com>]

在 2010年10月14日 下午5:37，cee1 <fykcee1 gmail com>写道：

Hi Dan,

I did some primary tests of patch for nm-openvpn, found it will lost secrets when shift from system scope to user scope(I.E. when user deselects "Available to all users").

Then I've verified this bug on the patch for nm-pptp, too.

 

This is a bug of NMA. Here is the detail:

(shift from NM_CONNECTION_SCOPE_SYSTEM to NM_CONNECTION_SCOPE_USER)

update_connection(connection-editor/nm-connection-list.c)

    -> add_connection

        -> nm_settings_interface_add_connection

            -> add_cb

                -> update_add_result_cb (passed in by add_connection)

                    -> delete_connection

                        -> nm_settings_connection_interface_delete

                            -> delete_cb

                                -> update_remove_result_cb (passed in by delete_connection)

In delete_cb, vpn secrets are deleted unexpectedly:

if (!error && (scope == NM_CONNECTION_SCOPE_USER)) {

    /* Clean up VPN secrets and any plugin-specific data */