Re: NetworManager and openconnect: using cookies

[muriloo br ibm com]

David Woodhouse <dwmw2 infradead org> wrote on
10/09/2010 08:25:37 AM:

> David Woodhouse <dwmw2 infradead org> 
> 10/09/2010 08:25 AM
> 
> To
> 
> muriloo br ibm com
> 
> cc
> 
> "ebarkie us ibm com" <ebarkie us ibm com>, "networkmanager-
> list gnome org" <networkmanager-list gnome org>, openconnect-
> devel lists infradead org
> 
> Subject
> 
> Re: NetworManager and openconnect: using cookies
> 
> On Fri, 2010-10-08 at 11:03 -0300, muriloo br ibm com wrote:
> > 
> > Thanks for your reply David. 
> > 
> > I think we could implement keyring support for password first
and after 
> > implement a function to test if cookie is still valid and save
cookie in 
> > gnome-keyring either. 
> 
> Yeah, that definitely sounds like the sanest approach.
> 
> 
> > For now, I've drafted a patch to add gnome-keyring support for
user's 
> > password. Please refer to the attachment openconnect-add-gnome-
> keyring-support.patch 
> 
> Hm, that doesn't seem generic enough. Remember, the server can present
> you with *arbitrary* forms to fill in. Some text input boxes are marked
> as 'text' and some are marked as 'password' but there can be any number
> of each. Just because it's *common* to have a single username and
a
> single password entry, that doesn't mean it's all we have to cope
with.
> 
> See how the non-password entries are saved in gconf with under a key
> named 'form:$AUTH_ID:$OPT_NAME'? We want something similar for password
> entries, I think -- so it can save *any* of the text boxes, not just
> one.
> 
> Or am I misreading your patch?
> 
> -- 
> dwmw2
> 

Hi David,

your comments make sense. I really appreciated.

See my comments below and help me find the best way
to follow.

I'm wondering on creating a function 'remember_keyring_key'
that will store
'form->auth_id', 'data->opt->name' and 'username'.

Add other attributes 'auth_id' and 'auth_value' in
keyring_password_schema.

Create a function 'find_form_password' that will return
the password saved in
gnome-keyring according to 'form->auth_id', 'data->opt->name'
and 'username'.

These functions will be called inside the loops instead
of directly calling
gnome_keyring_* functions.

I think that way it will save all password entries
in the keyring.

Thanks in advance,

Murilo