Re: NetworManager and openconnect: using cookies

[David Woodhouse <dwmw2 infradead org>]

On Mon, 2010-10-11 at 15:09 -0300, muriloo br ibm com wrote:
> @@ -590,6 +641,11 @@ int nm_process_auth_form (struct openconnect_info *vpninfo,
>               keyname = g_strdup_printf("form:%s:%s", form->auth_id, data->opt->name);
>               remember_gconf_key(ui_data, keyname, strdup(data->entry_text));
>         }
> +       /* save user password in gnome-keyring */
> +       if (data->opt->type == OC_FORM_OPT_PASSWORD) {
> +             remember_keyring_key(data->opt->name, strdup(data->entry_text));
> +       } 

Hrm, why not using the *same* 'keyname' string as we're using for the
TEXT and SELECT cases? There was a reason we included the form->auth_id
in that key.

Other than that, it looks good. Will be nice to extend it to save the
*cookie* too, so that it doesn't have to log in again at all.

-- 
David Woodhouse                            Open Source Technology Centre
David Woodhouse intel com                              Intel Corporation