Re: keyfile plugin initialization and wireless at boot

[Jirka Klimes <jklimes redhat com>]

On Friday 23 of April 2010 02:12:46 Dan Williams wrote:
> On Tue, 2010-04-20 at 17:48 +0200, Jirka Klimes wrote:
> > I've tried that as well and can confirm a problem.
> > 
> > I rebooted to Ubuntu and added this line to /etc/network/interfaces
> > iface eth0 inet dhcp
> > That triggers the problem.
> 
> > I looked into it a bit to find the cause. This is what is going on, IMO:
> Good diagnosis, though I think what we should do is something like this:
> 
> diff --git a/src/system-settings/nm-sysconfig-settings.c
> b/src/system-settings/nm-sysconfig-settings.c index 0054a99..4bcfb04
> 100644
> --- a/src/system-settings/nm-sysconfig-settings.c
> +++ b/src/system-settings/nm-sysconfig-settings.c
> @@ -357,8 +357,6 @@ add_plugin (NMSysconfigSettings *self,
> NMSystemConfigInterface *plugin)
> 
>  	g_signal_connect (plugin, NM_SYSTEM_CONFIG_INTERFACE_CONNECTION_ADDED,
>  	                  G_CALLBACK (plugin_connection_added), self);
> -	g_signal_connect (plugin,
> NM_SYSTEM_CONFIG_INTERFACE_UNMANAGED_SPECS_CHANGED, -	                 
> G_CALLBACK (unmanaged_specs_changed), self);
>  	g_signal_connect (plugin, "notify::hostname", G_CALLBACK
> (hostname_changed), self);
> 
>  	nm_system_config_interface_init (plugin, NULL);
> @@ -368,6 +366,9 @@ add_plugin (NMSysconfigSettings *self,
> NMSystemConfigInterface *plugin) NM_SYSTEM_CONFIG_INTERFACE_INFO, &pinfo,
>  	              NULL);
> 
> +	g_signal_connect (plugin,
> NM_SYSTEM_CONFIG_INTERFACE_UNMANAGED_SPECS_CHANGED, +	                 
> G_CALLBACK (unmanaged_specs_changed), self);
> +
>  	nm_log_info (LOGD_SYS_SET, "Loaded plugin %s: %s", pname, pinfo);
>  	g_free (pname);
>  	g_free (pinfo);
> @@ -1328,6 +1329,7 @@ nm_sysconfig_settings_new (const char *config_file,
>  			g_object_unref (self);
>  			return NULL;
>  		}
> +		unmanaged_specs_changed (NULL, self);
>  	}
> 
>  	return self;
> 
> can you test and see if that works?  If so, feel free to push to git.
> 
> Thanks!
> Dan
> 

I've tested and it looks good. Thanks!
Commited to master: a4cc8873c9981176575c0939c63473b4206db72c

Jirka