Re: Question about function applet_get_best_activating_connection()



On Wed, Sep 16, 2009 at 05:54, 代尔欣 <daierxin gmail com> wrote:
> Hi all,
>    In applet.c function applet_get_best_activating_connection() have codes:
>
>         ...
>         if (NM_IS_DEVICE_WIFI (best_dev)) {
>             if (NM_IS_DEVICE_ETHERNET (candidate)) {
>                 best_dev = candidate_dev;
>                 best = candidate;
>             }
>         }
>         ...
>
> Is NM_IS_DEVICE_ETHERNET (candidate) correct? The 'candidate' type is
> NMActiveConnection. It should use candidate_dev instead?

Fixed, thanks!

Tambet


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]