Re: Mobile Broadband -> Disconnect option broken? [PATCH]

[Raul Gutierrez Segales <rgs rieder net py>]

Dan, 

The attached patch fixed the problem for me. The out_active variable
wasn't been assigned in applet_find_active_connection_for_device.

Sounds correct?

On Thu, 2009-05-07 at 13:47 -0400, Dan Williams wrote:
> On Thu, 2009-05-07 at 11:17 -0400, Raul Gutierrez Segales wrote:
> > Dan,
> > 
> > On Thu, 2009-05-07 at 10:51 -0400, Dan Williams wrote:
> > > On Mon, 2009-05-04 at 23:50 -0400, Raul Gutierrez Segales wrote:
> > > > Hi,
> > > > 
> > > > I am running Network Manager version 0.7.1~rc4.1.cf199a964-0ubuntu2 on
> > > > Ubuntu 9.04.
> > > > 
> > > > For some reason that I haven't been able to debug yet, the
> > > > network-manager-applet completely ignores the disconnect command for 3G
> > > > GSM connection. 
> > > > 
> > > > My 3G modem is a (output from lsusb) :
> > > > 
> > > > Bus 005 Device 002: ID 12d1:1003 Huawei Technologies Co., Ltd. E220
> > > > HSDPA Modem / E270 HSDPA/HSUPA Modem
> > > > 
> > > > Is this known to be broken? Seems like a matter of capturing the event
> > > > and killing pppd (I have to do it by hand now..). 
> > > 
> > > I'd need some logs from /var/log/messages, /var/log/daemon.log,
> > > or /var/log/NetworkManager.log (wherever your distro puts NM log output
> > > which goes to the syslog 'daemon' facility), and then some logs from
> > > ~/.xsession-errors, which is where applet error output would go.
> > > 
> > 
> > Nothing interesting comes out on /var/log/daemon.log (daemon facility)
> > when trying to disconnect, I am attaching it though. 
> > 
> > 
> > But here is what I got on ~/.xsession-errors when clicking the
> > Disconnect item :
> > 
> > ** (nm-applet:4990): WARNING **: gsm_menu_item_deactivate: couldn't find
> > active connection to deactive
> 
> When you get this error, can you run 'nm-tool' and tell me what the
> output is?
> 
> dan
> 
> 
> 

Index: src/applet.c
===================================================================
--- src/applet.c	(revision 1278)
+++ src/applet.c	(working copy)
@@ -977,8 +977,12 @@
 			NMDBusConnection *tmp;
 
 			tmp = nm_dbus_settings_get_connection_by_path (applet->dbus_settings, connection_path);
-			if (tmp)
+			if (tmp) {
 				connection = nm_exported_connection_get_connection (NM_EXPORTED_CONNECTION (tmp));
+				if (out_active)
+					*out_active = active;
+				break;
+			}
 		} else if (!strcmp (service_name, NM_DBUS_SERVICE_USER_SETTINGS)) {
 			NMAGConfConnection *tmp;