Fedora 10; openvpn plugin, treat tun devices as tap devices in relation to netmask (do not hardcode tun to /32)

[Ove Everlid <Ove Everlid sun com>]

Hi!

To connect to an OpenVPN server that uses tun-devices with a non /32 
netmask one need this patch. I'm using NetworkManager under Fedora 10 
(same issues still exists in F11 alpha/rawhide).

The patch is the quick fix but the special treatment of tun/tap relative 
network mask can be removed.

Question; will removing the tun /32 netmask hard coding cause other issues.

Ove



[root oehplap NetworkManager]# diff -c 
nm-openvpn-service-openvpn-helper.c 
nm-openvpn-service-openvpn-helper.c.fc10.orig
*** nm-openvpn-service-openvpn-helper.c	2009-03-22 22:13:35.227415799 +0100
--- nm-openvpn-service-openvpn-helper.c.fc10.orig	2009-01-28 
18:38:30.000000000 +0100
***************
*** 339,345 ****
  	 * TAP devices pass back the netmask, while TUN devices always use /32
  	 * since they are point-to-point.
  	 */
! 	if (tapdev || 1) {
  		tmp = getenv ("ifconfig_netmask");
  		if (tmp && inet_pton (AF_INET, tmp, &temp_addr) > 0) {
  			GValue *val;
--- 339,345 ----
  	 * TAP devices pass back the netmask, while TUN devices always use /32
  	 * since they are point-to-point.
  	 */
! 	if (tapdev) {
  		tmp = getenv ("ifconfig_netmask");
  		if (tmp && inet_pton (AF_INET, tmp, &temp_addr) > 0) {
  			GValue *val;
[root oehplap NetworkManager]#



--
Ove Everlid
MySQL Senior Systems Architect
Mobile: +46706662363
Office: +4618174410 (Time Zone MET)
Skype handle: oveeve