Re: Fixing some small issues

[Dan Williams <dcbw redhat com>]

On Fri, 2009-07-03 at 22:45 +0200, Marvin Schmidt wrote:
> Hey there,
> 
> I recently tried NetworkManager and ModemManager from git and my
> UMTS stick, which used to cause me a lot of trouble, worked out of the
> box without editing udev rules or any of that, good job!
> 
> Though there were 3 minor problems, which were trivial to fix:
> 
> 1) 
>    When running ModemManager's ./autogen.sh I got:
>    
>       configure.in:71: required file `callouts/Makefile.in' not found
> 
>    This is obviously a left-over and shouldn't be there anymore

Hmm, that should not longer be the case as of:

commit 7c46bbfd9ee0cf8e38fd75dbbb24f6cf4fdb81af
Author: Michael Biebl <biebl debian org>
Date:   Tue Apr 21 00:46:22 2009 +0200

what exact snapshot of the code are you using?

> 
> 2) 
>    When compiling ModemManager I got:
>    
>       mm-generic-cdma.c: In function 'serving_system_done':
>       mm-generic-cdma.c:507: error: cast to pointer from integer of
> different size
> 
>    I'm not really sure about that, but using GSIZE_TO_POINTER fixed it

Odd, since a 'char' is supposed to be only 8 bits.  Does it work if you
change it to 'unsigned char' ?

> 
> 3) 
>    NetworkManager's initscript for Gentoo (and probably others too)
>    have a dependency upon HAL, but nowadays it should just depend on  
>    dbus

Thanks, fixed

Dan

> 
> The attached patches fix these problems as described
> 
> 
> Best regards,
> Marvin Schmidt
> _______________________________________________
> NetworkManager-list mailing list
> NetworkManager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list