Re: [PATCH] Disabling/enabling notifications in NM 0.7.2] (resend)

On Fri, 2009-12-04 at 21:04 +0000, Alex Buell wrote:
> -------- Forwarded Message --------
> > From: Alex Buell <alex buell munted org uk>
> > Reply-to: alex buell munted org uk
> > To: Dan Williams <dcbw redhat com>
> > Cc: networkmanager-list gnome org
> > Subject: [PATCH] Disabling/enabling notifications in NM 0.7.2
> > Date: Thu, 26 Nov 2009 18:49:01 +0000
> > 
> > Here is version 2 of the patch, changes include moving from the old
> > preferences dialog to the right click menu, which I agree is a far
> > better option. It's all complete now, thanks for your kind attention. 
> > 
> > I enjoyed myself hacking upon NetworkManager 0.7.2, hopefully I may do
> > some more hacking in the future!
> > 
> > Patch is attached.

Would you have any objection to collapsing the two checkboxes into just
one labeled "Show notifications"?  For most people it's probably not
useful to show only connect but not disconnect or vice-versa; the people
who really want that can still use GConf to do so.  Other than that,
good work; let me know if you don't mind re-doing the patch, otherwise
I'll get around to it.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]