nm-applet crashes in VNC

[Jeffrey Bastian <jbastian redhat com>]

I'm running Fedora 11 on PowerPC.

I started a VNC session this morning and nm-applet crashed with a 
"double free or corruption" error when trying to free some memory.  I 
tracked it down to an uninitialized 'error' variable in 
src/applet-dbus-manager.c

The problem still exists in the git devel tree.  Attached is a patch 
that fixes the problem for me.

More details on the crash are at
  https://bugzilla.redhat.com/show_bug.cgi?id=519408

Jeff Bastian

diff --git a/src/applet-dbus-manager.c b/src/applet-dbus-manager.c
index 68cce7f..2059f03 100644
--- a/src/applet-dbus-manager.c
+++ b/src/applet-dbus-manager.c
@@ -139,7 +139,7 @@ static gboolean
 request_name (DBusGProxy *proxy, int flags, const char *detail)
 {
 	int request_name_result;
-	GError *error;
+	GError *error = NULL;
 
 	if (!dbus_g_proxy_call (proxy, "RequestName", &error,
 	                        G_TYPE_STRING, NM_DBUS_SERVICE_USER_SETTINGS,
@@ -147,9 +147,12 @@ request_name (DBusGProxy *proxy, int flags, const char *detail)
 	                        G_TYPE_INVALID,
 	                        G_TYPE_UINT, &request_name_result,
 	                        G_TYPE_INVALID)) {
-		nm_warning ("Could not acquire the %s service.\n"
-		            "  Message: '%s'", detail, error->message);
-		g_error_free (error);
+		if (error) {
+			nm_warning ("Could not acquire the %s service.\n"
+					"  Message: '%s'", detail, 
+					error->message);
+			g_error_free (error);
+		}
 		return FALSE;
 	}