Re: dnsmasq

[Howard Chu <hyc symas com>]

Alexander Sack wrote:
> Hi,
>
> some initial comments:

Thanks for looking at this.

> Instead of iterating here on your own, couldnt you use the "composite"
> IP4 config by moving the dnsmasq_update function call further down here:

No, because the composite merges the VPN settings with everything else, and 
I'm pretty sure the VPN DNS settings should remain isolated. That's what all 
the bother with

                /* assume VPN nameserver should only be used for
                 * the VPN's domain
                 */

is about. At least, for the VPNs I've used, they set you up with a DNS server 
inside a firewall that knows about internal/private domains. While such 
servers may be able to answer queries for external domains, other servers 
certainly cannot answer queries for internal domains. Also, since VPNs tend to 
be slower than raw networks, keeping the DNS servers segregated like this 
ensures that only uncached queries for private domains will go over the slow 
link, everything else will go over the faster link.

With dnsmasq, if you specify a domain name after a nameserver address, that 
server will only be used to satisfy queries within that domain.

(See the dnsmasq DBUS documentation here
 http://www.thekelleys.org.uk/dnsmasq/docs/DBus-interface )

> >   static void
> > Index: named-manager/nm-named-manager.h
> > ===================================================================
> > --- named-manager/nm-named-manager.h	(revision 4043)
> > +++ named-manager/nm-named-manager.h	(working copy)
> > @@ -26,6 +26,7 @@
> >   #include "config.h"
> >   #include<glib-object.h>
> >   #include<dbus/dbus.h>
> > +#include<dbus/dbus-glib-lowlevel.h>
> >   #include "nm-ip4-config.h"
> >
> >   typedef enum {
>
> Is there a particular reason to put that include here instead of the
> .c file where its used?

Not really. I put it where <dbus/dbus.h> was included because they're related, 
but you're right, it should just go in the .c file.

--
  -- Howard Chu
  CTO, Symas Corp.           http://www.symas.com
  Director, Highland Sun     http://highlandsun.com/hyc/
  Chief Architect, OpenLDAP  http://www.openldap.org/project/