Re: [PATH]: modem-manager: fix for coldstart connect problem + parser hooks for unsolicited msgs

From: "Tambet Ingo" <tambet gmail com>
To: "Per Hallsmark" <per hallsmark t2data se>
Cc: networkmanager-list gnome org
Subject: Re: [PATH]: modem-manager: fix for coldstart connect problem + parser hooks for unsolicited msgs
Date: Tue, 28 Oct 2008 15:55:33 +0200

Hey,

A couple of comments:

* Both new regexps and std_parser are leaked. Dereference them in finalize().
* No need to create an empty callback (msg_waiting), you can just send NULL to
mm_util_strip_string().

Thanks,
Tambet

References:
- [PATH]: modem-manager: fix for coldstart connect problem + parser hooks for unsolicited msgs
  - From: Per Hallsmark

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]