Re: [PATCH] Support default path for importing openvpn configuration file

On Fri, 2008-10-24 at 23:41 +0800, Bin Li wrote:
> On Fri, Oct 24, 2008 at 10:53 PM, Dan Williams <dcbw redhat com> wrote:
> > On Fri, 2008-10-24 at 11:36 +0300, Tambet Ingo wrote:
> >> It leaks 'default_path' variable in do_import(). I'd also use
> >> g_build_filename() in handle_path_item() in case the path isn't
> >> absolute.
> >
> > Yeah, other than that, looks good though.  If you could post it again
> > when this is cleaned up, then we can commit.
> Tambet, do you commit your change?  Do you need I change it like your said?

Yeah, if you could provide an updated patch that would be great.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]