Re: [PATCH] hal probe modem caps ondemand



2008/5/14, Marcel Holtmann <marcel holtmann org>:
> If we can annotate the modem caps via FDI files using the USB vendor and
>  product id, I am for doing that. Having HAL open the TTY device is not a
>  good idea. Especially since not all GSM/UMTS/CDMA modem follow clear
>  standards and some of them are picky about the AT commands that are sent
>  and in which order.

I am strongly against vendor/product id approach. There are possibly
hundreds of different modem/phone products out there and new ones come
out all the time. I think that marking at least CDC ACM device class
as generic modems and then probing them for GSM/CDMA capabilites is
the best thing to do. If there are exceptional or buggy products which
can't be probed that way, then annotate them by hand via fdi.

-- 
Alexander


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]