Re: [PATCH] Don't hardcode path names in system service files.



On Tue, 2008-04-29 at 20:46 +0200, Michael Biebl wrote:
> Michael Biebl schrieb:
> > callouts/org.freedesktop.nm_dispatcher.service and
> > system-settings/src/org.freedesktop.NetworkManagerSystemSettings.service
> > use hardcoded path names like /usr/sbin and /usr/libexec.
> > 
> > This is problematic, as e.g. Debian/Ubuntu don't have /usr/libexec or if
> > you want to install into /usr/local.
> > 
> > The attached patch uses @libexecdir@ and @sbindir@ and processes
> > *service.in files to create the final service files.
> > 
> > Before applying the patch, please run
> > 
> > svn mv org.freedesktop.NetworkManagerSystemSettings.service
> > org.freedesktop.NetworkManagerSystemSettings.service.in
> > 
> > in system-settings/src/ and
> > 
> > svn mv org.freedesktop.nm_dispatcher.service
> > org.freedesktop.nm_dispatcher.service.in
> > 
> > in callouts/. Otherwise the svn history is not correctly presevered (svn
> > is too dumb unfortunately).
> 
> I just noticed, that NM already uses GNU make extensions. So I
> simplified the patch a bit and made use of %-style pattern rules.
> Updated patch attached.

Committed, thanks!

Dan



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]