DBus Properties?



Hi,

I was just working on getting all seen bssids into the appropriate connection 
in KNetworkManager while roaming between several APs.

The wireless device provides a DBus signal "PropertiesChanged" which is useful 
for updating the seen_bssids property. Unfortunately the properties name 
provided in "PropertiesChanged" is not the same as the one defined in 
nm-device-802-11-wireless.h but the one from nm-device-802-11-wireless.c.

Shouldn't the properties DBus-names be available in the header file too?

Just have a look at the attached patch to see what I mean :)

The patch is not meant for committing as the identifier-names should be 
cleaned up first.

Thanks,
Helmut
Index: nm-device-802-11-wireless.c
===================================================================
--- nm-device-802-11-wireless.c	(Revision 3372)
+++ nm-device-802-11-wireless.c	(Arbeitskopie)
@@ -35,12 +35,6 @@
 	LAST_PROP
 };
 
-#define DBUS_PROP_HW_ADDRESS "HwAddress"
-#define DBUS_PROP_MODE "Mode"
-#define DBUS_PROP_BITRATE "Bitrate"
-#define DBUS_PROP_ACTIVE_ACCESS_POINT "ActiveAccessPoint"
-#define DBUS_PROP_WIRELESS_CAPABILITIES "WirelessCapabilities"
-
 enum {
 	ACCESS_POINT_ADDED,
 	ACCESS_POINT_REMOVED,
Index: nm-device-802-11-wireless.h
===================================================================
--- nm-device-802-11-wireless.h	(Revision 3372)
+++ nm-device-802-11-wireless.h	(Arbeitskopie)
@@ -19,6 +19,12 @@
 #define NM_DEVICE_802_11_WIRELESS_ACTIVE_ACCESS_POINT "active-access-point"
 #define NM_DEVICE_802_11_WIRELESS_CAPABILITIES        "wireless-capabilities"
 
+#define DBUS_PROP_HW_ADDRESS "HwAddress"
+#define DBUS_PROP_MODE "Mode"
+#define DBUS_PROP_BITRATE "Bitrate"
+#define DBUS_PROP_ACTIVE_ACCESS_POINT "ActiveAccessPoint"
+#define DBUS_PROP_WIRELESS_CAPABILITIES "WirelessCapabilities"
+
 typedef struct {
 	NMDevice parent;
 } NMDevice80211Wireless;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]