Re: Couple of minor issues with 0.7

[Dan Williams <dcbw redhat com>]

On Mon, 2008-07-21 at 14:30 -0400, Darren Albers wrote:
> On Mon, Jul 21, 2008 at 12:27 PM, Dan Williams <dcbw redhat com> wrote:
> > On Sun, 2008-07-20 at 14:50 -0400, Darren Albers wrote:
> <snip>
> >
> >> Jul 20 14:46:20 dpalap NetworkManager: <info>  Trying to start the
> >> system settings daemon...
> >>
> >> When I edit any VPN settings I get:
> >> ** (nm-connection-editor:9275): WARNING **: Invalid setting VPN: key
> >> /bin/sh: /bin/awk: not found
> >
> > So this is really weird and a bug.  What VPN plugin are you using?  This
> > comes from the UI validation code in the connection editor and could
> > indicate a bug in the VPN plugin.
> >
> 
> This was on the OpenVPN plugin, I plan on updating to the snapshot
> from today and trying the PPTP plugin so I will let you know if it is
> still happening.

Ok, that's probably the bits that try to check for the OpenVPN cipher
list which actually spawn out some shell.  That should be better
protected.

> <snip>
> >> 2)  Recent SVN snapshots prompt me for a password for my card but it
> >> doesn't actually require one.   Maybe a box that says "My Provider
> >> does not require one" and if you check that box something random is
> >> sent.   While I know that I can enter anything there, it is likely
> >> that a less technical user will not realize that.
> >
> > Yeah, I thought I'd nailed that one but the code would work better with
> > an explicit "doesn't require authentication" checkbox.  However, if we
> > can fix the current behavior without an additional checkbox, that would
> > be better.  If that's not possible (and the current code is a bit ugly)
> > then a checkbox like you suggest would be the next best solution.  Does
> > your provider require a username but not a password?  Or do you not need
> > any auth credentials?
> 
> I don't think it requires any credentials, this is with AT&T.

Ok.  I've got access to an AT&T card so I can check it out.  svn r3801
and later were specifically supposed to fix this but I'll re-check.

Dan