Re: [PATCH] Enable dhcpcd instead of dhclient

[Dan Williams <dcbw redhat com>]

On Thu, 2008-07-17 at 14:44 +0200, Michael Biebl wrote:
> Roy Marples wrote:
> > On Thu, 2008-07-17 at 04:36 +0200, Michael Biebl wrote:
> >> Roy Marples wrote:
> >>> On Tue, 15 Jul 2008 15:29:43 +0100, Roy Marples <roy marples name> wrote:
> >>>> Please apply this to NetworkManager :)
> >> I don't quite like the configure bits yet. It forces you to have either 
> >> dhclient or dhcpd installed for a successful build.
> >>
> >> This effectively makes the dhcp client a build depenency.
> >> This doesn't really matter for a (source-based) distro like gentoo, but 
> >> on other distros, where the packages are built in a separate build 
> >> environment this means, that you now have to install a dhcp client.
> > 
> > The current configure environment forced me to install ppp for the
> > development headers. I neither use nor care about ppp, so the same
> > argument could be applied there.
> > 
> > The reason why it's a build time check is that it's a lot easier to
> > check the clients work in a shell script than in C at runtime.
> > 
> > 1) Only dhcpcd-4 works with NM - older versions will not
> > 2) Only ISC dhclient works with NM - derived versions will not
> > (OpenBSD and FreeBSD have their own trimmed down versions with POSIX
> > command line and don't have all the options needed)
> >
> 
> That doesn't necessarily work for binary distros though, as the 
> build-environment can differ from the run-time environment.
> 
> Imo, it's better to simply document such runtime dependencies (e.g. in a 
> README file), so the package maintainer can enforce the correct software 
> versions via dependencies in the package management system.

I don't have a problem with that.  So lets:

1) if given a full path that ends in dhclient or dhcpcd, don't do
further checks just use that
2) Document the required versions in the README
3) If nothing is found or specified, default to dhclient since that's
what it's been up until now

Thoughts?

Dan

> Cheers,
> Michael
> 
> 
> _______________________________________________
> NetworkManager-list mailing list
> NetworkManager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list