Re: [PATCH] resolvconf support (Re: NM 0.7 Debian Lenny - strangest issue...)



Alexander Sack wrote:
On Tue, Jul 08, 2008 at 05:07:21PM +0200, Alexander Sack wrote:
On Tue, Jul 08, 2008 at 04:42:39PM +0200, Michael Biebl wrote:
I wouldn't necessarily add a configure flag and #ifdef WITH_RESOLVCONF.

I'd simply check at runtime, if the resolvconf binary is available ( g_file_test (RESOLVCONF, G_FILE_TEST_IS_EXECUTABLE)) { .. } )
OK, I didnt do that because I assumed that this is a debian/ubuntu
only thing. However, I could easily change it obviously.

(However, the fallbacks will still be necessary in case someone trashed
resolvconf by replacing the /etc/resolv.conf link with a file.)

I forgot: the ifdef WITH_RESOLVCONF doesnt mean "resolvconf will
exist", it just means: "try to use resolvconf".

So it just ment as a way to disable it for distros that dont have
resolvconf anyway.

Yeah, I guess you are right. It probably doesn't make sense to check for /sbin/resolvconf on distros, which don't even ship that tool in their archives.

Michael
--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]