Re: [PATH] Support resolvconf

[Alexander Sack <asac jwsdot com>]

On Sun, Aug 24, 2008 at 12:13:00PM +0100, Roy Marples wrote:
> > -	if (searches || nameservers) {
> > +	if ( (searches && *searches && strlen(*searches)) ||
> > +	     (nameservers && *nameservers && strlen(*nameservers))) {
> >  		cmd = g_strconcat (resolvconf, " -a ", "NetworkManager", NULL);
> >  		nm_info ("(%s): writing resolv.conf to %s", iface, resolvconf);
> >  		if ((f = popen (cmd, "w")) == NULL)
> > 
> 
> That should not be needed, unless a config entry itself contains a null
> string. In this instance, probably better to fix it at source if input
> rather than in the processing here.
> 

Right. I just checked. Not sure why that didnt work out-of-box on the
first run here. Now it works.

Thus, ack from me on this.

 - Alexander