Re: [PATCH] Enable dhcpcd instead of dhclient



On Fri, 2008-08-22 at 21:02 +0200, Michael Biebl wrote:
> Roy Marples wrote:
> > On Fri, 2008-08-08 at 18:25 +0200, Michael Biebl wrote:
> >> Roy Marples wrote:
> >>> +if ! test -f src/dhcp-manager/nm-dhcp-"${DHCP_CLIENT}".c; then
> >>> +	AC_MSG_ERROR([No backend for the DHCP client ${DHCP_CLIENT}])
> >>> +fi
> >> This check fails for srcdir != builddir => "make distcheck" will fail.
> > 
> > I'm no autoconf guru :)
> > You can either fail during compile with --with-dhcp-client=/bin/true
> > that nm-dhcp-true.c does not exist, or try and detect borkage at
> > configure time.
> > 
> > Can you suggest anything better?
> > 
> 
> I commited a refined check as r4002 which should address all mentioned
> issues.

Looks good :)

Thanks

Roy



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]